Prevent crashing on servers #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, any update on this? |
|
There are unnecessary changes in this PR that I don't want to merge |
|
Which unnecessary changes exactly are you referring to? I think I accidentally clicked optimize imports in my IDE, which removed a few imports that were unrelated to the PR. Is that what you mean? |
|
Also waiting for updates |
JulianVennen
force-pushed
the
1.20.1-new
branch
from
4af4aca to
7a32488
Compare
|
I rebased the changes to resolve conflicts and undid any unnecessary changes to the import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to start a server with oculus installed it causes a crash because oculus attempts to access client-only code.
According to the forge documentation client-only mods should work on servers: https://docs.minecraftforge.net/en/1.20.x/concepts/sides/#writing-one-sided-mods
This PR changed oculus to only listen for events on the client and therefore prevents this kind of crash.
This supersedes #367.